Use the .node-version file to define node env for Github actions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedredmond
approved these changes
May 17, 2024
There was a problem hiding this comment.
As long as this doesn't break things for wonder-blocks (@juan), I'm all about less duplication!
|
I'm going to abandon this for now. It wasn't the solution I needed and I think it's just a tiny improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This repo's Github actions use the
setup-nodeaction and define thenode-versionwithin each action. We have a.node-versionfile that defines the version of Node to use for tooling, and thesetup-nodeaction understands how to use that file, so this PR migrates all Github actions to defer to.node-versionfor which Node to use. Less duplication.Issue: "none"
Test plan: