Update node-version file #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremywiebe
approved these changes
May 17, 2024
jeremywiebe
added a commit
to Khan/perseus
that referenced
this pull request
May 17, 2024
## Summary: Hopefully this fixes up our Node 18 vs 20 issues in Github actions for good. From the [release](https://github.com/Khan/changeset-per-package/releases/tag/v1.0.3): ## What's Changed * Update node-version file by @mark-fitzgerald in Khan/changeset-per-package#76 * Bump actions/setup-node from 3 to 4 by @dependabot in Khan/changeset-per-package#34 * Bump github/codeql-action from 2 to 3 by @dependabot in Khan/changeset-per-package#58 * Bump actions/upload-artifact from 3 to 4 by @dependabot in Khan/changeset-per-package#59 * Bump eslint from 8.51.0 to 8.56.0 by @dependabot in Khan/changeset-per-package#60 * Bump eslint-plugin-jest from 27.4.3 to 28.5.0 by @dependabot in Khan/changeset-per-package#78 * Bump @typescript-eslint/parser from 6.7.5 to 6.21.0 by @dependabot in Khan/changeset-per-package#79 * Bump prettier-eslint from 15.0.1 to 16.3.0 by @dependabot in Khan/changeset-per-package#77 * Bump @typescript-eslint/eslint-plugin from 6.8.0 to 7.0.0 by @dependabot in Khan/changeset-per-package#80 **Full Changelog**: Khan/changeset-per-package@v1.0.2...v1.0.3 Issue: "none" ## Test plan: Author: jeremywiebe Reviewers: mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ⌛ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ✅ gerald, ⏭️ Publish npm snapshot, 🚫 Check builds for changes in size (ubuntu-latest, 20.x), 🚫 Cypress (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update the .node-version file to indicate v20.
Issue: XXX-XXXX