Properly fixed loading the extension twice

Author: Ketho

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Change Log
 
-## [0.17.3] - 2024-08-15
+## [0.17.4] - 2024-08-15
+- 0.17.4: Properly fixed loading the extension twice
 - 0.17.3: Fixed loading the extension twice when the "Activate WoW API extension" command is used
 - 0.17.2: Fixed [#163](https://github.com/Ketho/vscode-wow-api/issues/163) non-user paths for `Lua.workspace.library`
 - 0.17.1: Fixed `ScriptType` param-type-mismatch
@@ -140,6 +141,7 @@ To avoid loading for Lua projects not related to World of Warcraft, all settings
 - PR [#123](https://github.com/Ketho/vscode-wow-api/pull/123) Make childGroups optional in AceConfig.OptionsTable
 - PR [#120](https://github.com/Ketho/vscode-wow-api/pull/120) Add definition for tostringall()
 
+[0.17.4]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.4
 [0.17.3]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.3
 [0.17.2]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.2
 [0.17.1]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.1

src/extension.ts

@@ -2,13 +2,11 @@ import * as vscode from "vscode";
 import * as luals from "./luals";
 import * as subscriptions from "./subscriptions";
 
-let isLoaded = false;
-
 export async function activate(context: vscode.ExtensionContext) {
 	console.log("loaded", context.extension.id);
 	registerActivationCommand(context);
 
-	if (!isLoaded && (isWowWorkspace() || await hasTocFile())) {
+	if (isWowWorkspace() || await hasTocFile()) {
 		activateWowExtension(context);
 	}
 }
@@ -43,9 +41,10 @@ async function hasTocFile() {
 }
 
 function registerActivationCommand(context: vscode.ExtensionContext) {
+	let isLoaded = false;
 	const handler = () => {
 		if (!isLoaded) {
-			activateWowExtension(context);
+			isLoaded = true; // using a command already activates the extension
 			vscode.window.showInformationMessage("Activated WoW API extension.");
 		}
 		else {
@@ -68,5 +67,4 @@ async function activateWowExtension(context: vscode.ExtensionContext) {
 		luals.defineKnownGlobals();
 		luals.cleanupGlobals();
 	}
-	isLoaded = true;
 }