Fixed loading the extension twice

Author: Ketho

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Change Log
 
-## [0.17.2] - 2024-08-15
+## [0.17.3] - 2024-08-15
+- 0.17.3: Fixed loading the extension twice when the "Activate WoW API extension" command is used
 - 0.17.2: Fixed [#163](https://github.com/Ketho/vscode-wow-api/issues/163) non-user paths for `Lua.workspace.library`
 - 0.17.1: Fixed `ScriptType` param-type-mismatch
 - 0.17.0: Updated for release patch 11.0.2 (56071)
@@ -139,6 +140,7 @@ To avoid loading for Lua projects not related to World of Warcraft, all settings
 - PR [#123](https://github.com/Ketho/vscode-wow-api/pull/123) Make childGroups optional in AceConfig.OptionsTable
 - PR [#120](https://github.com/Ketho/vscode-wow-api/pull/120) Add definition for tostringall()
 
+[0.17.3]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.3
 [0.17.2]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.2
 [0.17.1]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.1
 [0.17.0]: https://github.com/Ketho/vscode-wow-api/releases/tag/0.17.0

src/extension.ts

@@ -8,7 +8,7 @@ export async function activate(context: vscode.ExtensionContext) {
 	console.log("loaded", context.extension.id);
 	registerActivationCommand(context);
 
-	if (isWowWorkspace() || await hasTocFile()) {
+	if (!isLoaded && (isWowWorkspace() || await hasTocFile())) {
 		activateWowExtension(context);
 	}
 }

src/luals.ts

@@ -169,14 +169,14 @@ vscode.workspace.onDidChangeConfiguration((event: vscode.ConfigurationChangeEven
 		const wv = (lib?.workspaceValue as string[]) ?? [];
 		const gv = (lib?.globalValue as string[] ?? []);
 		if (configScope === "User") {
-			const containsCfg = wv?.filter(el => el.includes("wow-api"));
-			const nocontainsCfg = wv?.filter(el => !el.includes("wow-api"));
+			const containsCfg = wv.filter(el => el.includes("wow-api"));
+			const nocontainsCfg = wv.filter(el => !el.includes("wow-api"));
 			lua_config.update("workspace.library", gv.concat(containsCfg), vscode.ConfigurationTarget.Global);
 			lua_config.update("workspace.library", nocontainsCfg.length>0 ? nocontainsCfg : undefined, vscode.ConfigurationTarget.Workspace);
 		}
 		else if (configScope === "Workspace") {
-			const containsCfg = gv?.filter(el => el.includes("wow-api"));
-			const nocontainsCfg = gv?.filter(el => !el.includes("wow-api"));
+			const containsCfg = gv.filter(el => el.includes("wow-api"));
+			const nocontainsCfg = gv.filter(el => !el.includes("wow-api"));
 			lua_config.update("workspace.library", wv.concat(containsCfg), vscode.ConfigurationTarget.Workspace);
 			lua_config.update("workspace.library", nocontainsCfg.length>0 ? nocontainsCfg : undefined, vscode.ConfigurationTarget.Global);
 		}