Revert "Fix parsing unknown fields breaks record deserialisation" #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksimu
approved these changes
Nov 22, 2024
| // New/missing field: Polymorphic serializer was not found for class discriminator 'UNKNOWN'... | ||
| // New/missing field property (field def updated): Encountered unknown key 'UNKNOWN'. | ||
| // Avoid 'ignoreUnknownKeys = true' to prevent erasing new properties on save/update | ||
| println("Record ${record.recordUid} has unexpected data properties (ignored).\n"+ |
There was a problem hiding this comment.
This message is very confusing, is the gateway ahead OR behind? can we cahnge it something like this:
println("Record ${record.recordUid} contains unrecognized data properties and could not be fully parsed.\n" +
"This may occur if the Keeper Secrets Manager (KSM) SDK version you're using is not compatible with the record's data schema.\n" +
"Please ensure that you are using the latest version of the KSM SDK. If the issue persists, contact [email protected] for assistance.")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #666