Implemented Sync security data command #102
Conversation
| from .proto import APIRequest_pb2, client_pb2, record_pb2 | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
There was a problem hiding this comment.
add constants at top like
PASSWORD_PADDING_LENGTH = 25 # Padding length to obfuscate password length in score data
RSA_ENCRYPTION_MAX_SIZE = 244 # Maximum size for RSA encryption (in bytes)
SECURITY_SCORE_UPDATE_CHUNK_SIZE = 1000 # Batch size for security data updates
STRONG_PASSWORD_THRESHOLD = 60 # Minimum score for a password to be considered strong
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def has_passkey(record: vault_record.KeeperRecord) -> bool: |
There was a problem hiding this comment.
Should it be private method? __has_passkey()
|
|
||
|
|
||
| def get_password(record: vault_record.KeeperRecord) -> Optional[str]: | ||
| """ |
| return None | ||
|
|
||
|
|
||
| def get_security_score(record: vault_record.KeeperRecord) -> Optional[int]: |
|
|
||
| Returns: | ||
| Password string or None if no password exists | ||
| """ |
There was a problem hiding this comment.
validate record with None
if not record:
|
|
||
| Returns: | ||
| True if password is considered strong (score >= 60) | ||
| """ |
There was a problem hiding this comment.
// Clamp score to valid range and validate as int
if not isinstance(score, int):
return False
score = max(0, min(100, score))
return score >= 60
|
|
||
| # Truncate domain string if needed | ||
| if diff < 0: | ||
| new_length = len(domain) + diff |
There was a problem hiding this comment.
add validation for new_length
if new_length > 0:
sec_data['domain'] = domain[:new_length]
else:
//If domain would be empty, don't include it
pass
|
|
||
| Returns: | ||
| SecurityData protobuf message or None on error | ||
| """ |
There was a problem hiding this comment.
validate record , vault
if not vault or not record:
return None
There was a problem hiding this comment.
Also record should have record_uid
if not hasattr(record, 'record_uid') or not record.record_uid:
logger.error('Record UID is missing')
return None
|
|
||
| Returns: | ||
| Encryption type constant from record_pb2 | ||
| """ |
|
|
||
| Returns: | ||
| Number of records successfully updated | ||
| """ |
| return sync_security_data_parser | ||
|
|
||
| def execute(self, context: KeeperParams, **kwargs): | ||
| if not context.vault: |
There was a problem hiding this comment.
add ''' '''' docs or comments of method
| if sap: | ||
| sap.set_reused_passwords(reused_count, 1) | ||
| except Exception: | ||
| pass |
No description provided.