Keeper fill implemented #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sali-ks
reviewed
Nov 25, 2025
|
|
||
| @staticmethod | ||
| def _format_url_for_display(url, verbose: bool) -> str: | ||
| """Format URL(s) for display, optionally truncating.""" |
There was a problem hiding this comment.
Inconsistent static method calls — mixin methods are called both via self and _KeeperFillMixin. Standardize on self for consistency.
def _format_url_for_display(self, url, verbose: bool) -> str
sali-ks
reviewed
Nov 25, 2025
| return _KeeperFillMixin._truncate_text(url) | ||
| elif isinstance(url, list) and url: | ||
| first_url = url[0] | ||
| return _KeeperFillMixin._truncate_text(first_url) |
sali-ks
reviewed
Nov 25, 2025
| return '' | ||
|
|
||
| if isinstance(url, str): | ||
| return _KeeperFillMixin._truncate_text(url) |
sali-ks
reviewed
Nov 25, 2025
|
|
||
| @staticmethod | ||
| def resolve_records(context: KeeperParams, **kwargs) -> Iterator[str]: | ||
| """ |
There was a problem hiding this comment.
def resolve_records(self, context: KeeperParams, **kwargs) -> Iterator[str]:
sali-ks
reviewed
Nov 25, 2025
| records = set() | ||
|
|
||
| for path in paths: | ||
| record_uid = _KeeperFillMixin._try_resolve_as_record(vault_data, path) |
There was a problem hiding this comment.
record_uid = self._try_resolve_as_record(vault_data, path)
sali-ks
reviewed
Nov 25, 2025
| if not pattern: | ||
| folders.append(folder) | ||
| else: | ||
| records.update(_KeeperFillMixin._get_records_matching_pattern(vault_data, folder, pattern)) |
There was a problem hiding this comment.
records.update(self._get_records_matching_pattern(vault_data, folder, pattern))
sali-ks
reviewed
Nov 25, 2025
|
|
||
| for folder in folders: | ||
| if recursive: | ||
| yield from _KeeperFillMixin._get_records_in_folder_tree(vault_data, folder) |
There was a problem hiding this comment.
yield from self._get_records_from_folder(vault_data, folder)
sali-ks
reviewed
Nov 25, 2025
| yield from records | ||
|
|
||
| @staticmethod | ||
| def _get_records_in_folder_tree(vault_data, folder) -> Iterator[str]: |
There was a problem hiding this comment.
def _get_records_in_folder_tree(self, vault_data, folder) -> Iterator[str]:
sali-ks
reviewed
Nov 25, 2025
|
|
||
| @staticmethod | ||
| def get_keeper_fill_data(context: KeeperParams, record_uid: str) -> Optional[dict]: | ||
| """ |
There was a problem hiding this comment.
def get_keeper_fill_data(self, context: KeeperParams, record_uid: str) -> Optional[dict]:
adeshmukh-ks
requested changes
Nov 25, 2025
Contributor
adeshmukh-ks
left a comment
adeshmukh-ks
left a comment
There was a problem hiding this comment.
keepercli implementations to be stopped going forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented "keeper-fill" command with it sub-command "list" and "set" for python SDK.