Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send yubikey prompts to the tty, as with user/pass #241

Closed
wants to merge 1 commit into from
Closed

Send yubikey prompts to the tty, as with user/pass #241

wants to merge 1 commit into from

Conversation

ad8-bdl
Copy link
Contributor

@ad8-bdl ad8-bdl commented May 8, 2020

No description provided.

@ad8-bdl
Copy link
Contributor Author

ad8-bdl commented May 8, 2020

Fixes #238

@ad8-bdl ad8-bdl changed the title Fixes #238 Send yubikey prompts to the tty, as with user/pass Send yubikey prompts to the tty, as with user/pass May 8, 2020
@sk-keeper
Copy link
Collaborator

This change is going to fail on Windows. /dev/tty
print('OK') will be replaced with with logging.info('OK')
You are right there is no need to print it to stdout

@sk-keeper
Copy link
Collaborator

I cannot merge this pull request as is. It contains two commits. Can you squash your commits into one and make commit description correct?

@ad8-bdl
Copy link
Contributor Author

ad8-bdl commented May 11, 2020

Done, ta.

@sk-keeper
Copy link
Collaborator

Merged into development repository

@sk-keeper sk-keeper closed this May 11, 2020
@ad8-bdl
Copy link
Contributor Author

ad8-bdl commented Oct 16, 2020

This appears to have not actually been merged?

@ad8-bdl ad8-bdl mentioned this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants