-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project names were incorrect. Changed them to the command menu path. The discovery_common code was not update to date. Update it.
Commands like ... * `pam action discover job remove` * `pam action discover job status` * `pam action discover process` were calling `gateway_helper.get_all_gateways` in a loop. Change the code to call the it outside of the loop and passed the list of gateways to the `from_configuration_uid`
…ank. DR-854 Don't allow local pamUser record reuse. During processing discovery, if existing local pamUser record is assigned to the resource don't let the same local pamUser record be used for another resource. The list of pamUser records to be converted are passed to 'find user' method. When we filter out users, use it to filter out/notifiy it's taken when list users. DR-866 Don't assigned resourceUid is IAM User. If the parent of the user is a provider, make sure the resourceUid for set rotation is None.
aaunario-keeper
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.