Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 16.11.23 #1345

Closed
wants to merge 7 commits into from
Closed

Release 16.11.23 #1345

wants to merge 7 commits into from

Conversation

sk-keeper
Copy link
Collaborator

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 27, 2024
View reviewed changes
keepercommander/commands/enterprise.py
template_value = _DEFAULT_PASSWORD_COMPLEXITY
if template_value:
with open(filepath, 'wt') as fd:
fd.write(template_value)

Check failure

Code scanning / CodeQL

Clear-text storage of sensitive information High

This expression stores
sensitive data (password)
Loading
as clear text.
This expression stores
sensitive data (password)
Loading
as clear text.

Copilot Autofix

AI 3 months ago

To fix the problem, we should encrypt the template_value before writing it to the file and decrypt it when reading it back. This ensures that the sensitive information is not stored in clear text. We can use the cryptography module to handle the encryption and decryption.

  1. Encrypt the template_value before writing it to the file.
  2. Decrypt the template_value when reading it back from the file.
  3. Add necessary imports and helper functions for encryption and decryption.
Suggested changeset 1
keepercommander/commands/enterprise.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/keepercommander/commands/enterprise.py b/keepercommander/commands/enterprise.py
--- a/keepercommander/commands/enterprise.py
+++ b/keepercommander/commands/enterprise.py
@@ -26,2 +26,3 @@
 from datetime import datetime as dt_module
+from cryptography.fernet import Fernet
 
@@ -49,2 +50,11 @@
 
+# Encryption key for Fernet (should be securely stored and managed)
+ENCRYPTION_KEY = b'your-encryption-key-here'  # Replace with your actual key
+fernet = Fernet(ENCRYPTION_KEY)
+
+def encrypt_value(value: str) -> bytes:
+    return fernet.encrypt(value.encode())
+
+def decrypt_value(value: bytes) -> str:
+    return fernet.decrypt(value).decode()
 
@@ -2193,4 +2203,5 @@
                                 if template_value:
-                                    with open(filepath, 'wt') as fd:
-                                        fd.write(template_value)
+                                    encrypted_value = encrypt_value(template_value)
+                                    with open(filepath, 'wb') as fd:
+                                        fd.write(encrypted_value)
                                     logging.warning('Enforcement "%s" value has been stored to file "%s"', key, filepath)
EOF
@@ -26,2 +26,3 @@
from datetime import datetime as dt_module
from cryptography.fernet import Fernet

@@ -49,2 +50,11 @@

# Encryption key for Fernet (should be securely stored and managed)
ENCRYPTION_KEY = b'your-encryption-key-here' # Replace with your actual key
fernet = Fernet(ENCRYPTION_KEY)

def encrypt_value(value: str) -> bytes:
return fernet.encrypt(value.encode())

def decrypt_value(value: bytes) -> str:
return fernet.decrypt(value).decode()

@@ -2193,4 +2203,5 @@
if template_value:
with open(filepath, 'wt') as fd:
fd.write(template_value)
encrypted_value = encrypt_value(template_value)
with open(filepath, 'wb') as fd:
fd.write(encrypted_value)
logging.warning('Enforcement "%s" value has been stored to file "%s"', key, filepath)
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
@sk-keeper sk-keeper closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sk-keeper @aaunario-keeper