Skip to content

Add some of the PypeIt CALSPEC flux standards #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

rremigio
Copy link

Added a few of the PypeIt CALSPEC flux standards to the stds folder. These are all WD stars with V_mag > 12, and wavelength coverage sufficient for very red KCRM setups. All stars are observable from Keck II with a maximum elevation of > 45 degrees.

I have not updated the spec_stats or stds_stats text files as I was unsure how to interpret some of the column names.

@rremigio rremigio requested a review from MNBrod as a code owner May 16, 2025 18:06
@MNBrod
Copy link
Contributor

MNBrod commented May 20, 2025

For the standards that already were in the pipeline, can you summarize what you did with the plots?

e.g. bd02d3375.png looks like a re-plot with extended coverage in the blue, but there's no corresponding change to the raw data for that target.

@rremigio
Copy link
Author

rremigio commented May 20, 2025

Regarding the plots that got replaced, this happened simply as a result of running the spec_stats.py script that was already in the standards folder, so whatever change between the old plots and the new ones is from there.

The script just sets log scaling on the y axis, and the x axis limits to min wavelength - 100 and min(12000 angstroms, wlmax) + 100. I can change this so its more consistent with the old plots going from ~3200 A to 1.1 micron (and update the .txt files too)

I have checked bd02d3375 specifically and it seems that the old plot for that object is likely based on a version of the spectrum that did not have the extended wavelength coverage (or it was probably trimmed to only have wavelengths within the KCWI wavelength range).

…d ones

change the markers to blue x, and fix  the x limits to be 3200 A to 11000 A. y limits are simply set to the maximum and minimum flux values within the KCWI wavelength range.
@MNBrod
Copy link
Contributor

MNBrod commented May 24, 2025

Sounds good to me, thanks for the explanation. I think you're right, the last time we added to the standards we must have forgotten to run the stats.

Sending to Rosalie for final approval, then we'll merge it in.

rremigio added 3 commits May 29, 2025 21:24
updated the information in the kcwi_stds_starlist.txt file.

Added stars in the standards folder that were previously unlisted, and added information on the WD stars added.

Removed a few existing standards that were the same as the WD stars.
Last updates taking into account the standards I added. Also adds entries for missing stars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants