Rename input_visualizer to test_case_visualizer; add *_visualizer_args #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #351.
I've tested the example visualizers in the "maximal" problem with https://github.com/RagnarGrootKoerkamp/BAPCtools/tree/draft-visualizer, with the following side-notes:
The visualizer in BAPCtools currently only generates images under
data/
with a propergenerators/generators.yaml
, so I temporarily wrote one:Temporary
generators/generators.yaml
:BAPCtools does not support the
include/
(yet?), so it should be invoked asbt generate --no-solution --no-validators
BAPCtools still uses
testdata.yaml
, I renamed this manually totest_group.yaml
after runningbt generate
Nonetheless, the "maximal" problem should be spec-compliant (and at some point in the future, BAPCtools should run it without issues as well) 😄