[pull] master from spinnaker:master #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* refactor(OAuth2): groovy to java conversion for OAuth module Validated and tested using google and github OAuth. * Add specific imports and remove * * Remove DefaultGroovyMethods * Add StructuredArguments.entries * Rename safeGet to toStringOrNull. toStringOrNull returns null when the input is null. Add javadoc * Replace details.getOrDefault with Optional to handle null cases * Add log statement from groovy code * Use AssertJ * First checks log.isDebugEnabled() to avoid unnecessary String concatenation * Add non empty string check * Add test for SpinnakerUserInfoTokenServices#isServiceAccount * Refactor SpinnakerUserInfoTokenServices to use constructor injection - Replaced member injection with constructor injection - Improved encapsulation by removing direct member access - Updated tests to pass dependencies via constructor * Preserve method call verifications in tests * Refactor to use constructor injection - Removed annotations from individual members - Added to the all-args constructor - Removed no-arg constructor to enforce dependency injection - Improved clarity and testability of the class * Add specific imports and remove * * Move SpinnakerProviderTokenServices to constructor argument and make it optional using Optional<SpinnakerProviderTokenServices>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )