feat(Sanitizer): enhance sanitization with ProcessorConfigBuilder and… #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… improved AttributeHandler - Add creation of `ProcessorConfigBuilder` instance in the constructor and pass it to `AttributeHandler`. - Update `AttributeHandler` to receive `ProcessorConfigBuilder` as an additional constructor parameter. - Modify the `sanitize` method to use `AttributeHandler` methods for obtaining messages and processing errors, providing a richer and more informative return structure. - Maintain the `sanitize` method signature to ensure compatibility with `SanitizerContract`. - Ensure `PropertyInspector` continues to function as before, as main changes are encapsulated within `AttributeHandler`. **Additional Considerations:** - Updated unit tests for `Sanitizer` to reflect the new return structure and modified internal logic. - Adjusted other classes that depend directly on `AttributeHandler` to accommodate similar changes. - Verified that the new return structure of the `sanitize` method is compatible with the rest of the system, updating usage points as necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… improved AttributeHandler
ProcessorConfigBuilderinstance in the constructor and pass it toAttributeHandler.AttributeHandlerto receiveProcessorConfigBuilderas an additional constructor parameter.sanitizemethod to useAttributeHandlermethods for obtaining messages and processing errors, providing a richer and more informative return structure.sanitizemethod signature to ensure compatibility withSanitizerContract.PropertyInspectorcontinues to function as before, as main changes are encapsulated withinAttributeHandler.Additional Considerations:
Sanitizerto reflect the new return structure and modified internal logic.AttributeHandlerto accommodate similar changes.sanitizemethod is compatible with the rest of the system, updating usage points as necessary.