Add support for neovim, newest pudb and atomize python code #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2017 08:57
Fix rel path issue Fix rel path issue part 2
Elkasitu
commented
Sep 13, 2017
|
|
||
| if !has("python") | ||
| echo "Error: Required vim compiled with +python" | ||
| if !has("python") && !has("python3") |
There was a problem hiding this comment.
Program will now execute correctly if (neo)vim has either +python or +python3 compilation flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim v0.2.0 support added (tested), shouldn't break vim support (not tested)
Newest pudb requires that bp objects contain a
condattribute, if they don't the program breaks and you get a traceback, solution for now is to assign None to self.cond during BP init, which works but is not ideal if anyone wants to actually add a BP condition.Python code is now within their own files for easier modification/readability.
Not mentioned in any of the commits but I added a check to see if (neo)vim was compiled with python3, so that if it was compiled with it, it wouldn't break because it didn't have +python but +python3, since the python code should be py2 and py3 compatible.
PS: Should probably check if neovim is being used instead of vim with has('nvim') and passing it as an arg to the python scripts