Support vim compiled with +python3 (e.g. Ubuntu 17.04) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows breakpoint to be set correctly when the python version that vim is compiled into is not the same as the python version that pudb would run as (e.g. when using virtualenv).
Drops support for vim with just +python
There was a race condition where set_breakpoint.py subprocess has not finished saving breakpoint when UpdateBreakPoints() is called.
In some systems, only `python` is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 17.04 dropped all vim packages that are compiled with python2. This pull request adds support for vim compiled only with +python3, in a way that also allows setting breakpoints in python2 projects.
pudb uses different breakpoint files for different python versions. As currently implemented, the vim-pudb will set breakpoint for the python version that is installed when running
python, so ifpythonrunspython2.7, vim-pudb will set breakpoint for pudb when running on python 2.7, but ifpythonrunspython3.5from virtualenv, vim-pudb will set breakpoint for pudb when running on python 3.5.Future improvements may be to have a setting to allow adding breakpoints to multiple versions at the same time (e.g.
let g:pudb_python_versions=['python2.7', 'python3.5', '/home/me/virtualenv/pypy2.7']).