Skip to content

Investigating flaky tests #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Avasam wants to merge 4 commits into
base: master
Choose a base branch
from
+116 −151
Draft

Investigating flaky tests #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32f0cef
Fail sooner on lacking macOS permissions, and actually fail test
Avasam Jun 19, 2026
e03b191
Fix pyright type issue
Avasam Jun 19, 2026
de2079f
WAIT_ATTEMPTS = 10 may not be enough on slow Linux CI
Avasam Jun 19, 2026
a8c5239
Extract _run_osascript with added timeout
Avasam Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/pywinctl/_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,4 +1054,3 @@ class _WINDICT(TypedDict): # noqa: PYI049 # Private symbol imported by internal
"PyWinCtl currently does not support this platform. "
+ "If you think you can help, please contribute! https://github.com/Kalmat/PyWinCtl"
)
Window = Window
2 changes: 1 addition & 1 deletion src/pywinctl/_pywinctl_linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

# WARNING: Changes are not immediately applied, specially for hide/show (unmap/map)
# You may set wait to True in case you need to effectively know if/when change has been applied.
WAIT_ATTEMPTS = 10
WAIT_ATTEMPTS = 15
WAIT_DELAY = 0.025 # Will be progressively increased on every retry


Expand Down
Loading