Localization support & translation #372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This thing can't be changed randomly
siimav
requested changes
Jul 20, 2025
Comment on lines
21
to
22
| @title = Procedural Real Fuels Tank | ||
| @description ^= :^:Baseline tank type. Accepts most fuels. Can be switched between unpressurised, balloon, cryogenic, ballooon cryo, and service module types. : | ||
| @title = #PP_Parts_TankRealFuels_title //Procedural Real Fuels Tank | ||
| @description ^= #PP_Parts_TankRealFuels_description //: Baseline tank type. Accepts most fuels. Can be switched between unpressurised, balloon, cryogenic, ballooon cryo, and service module types. |
There was a problem hiding this comment.
This changes the meaning of the MM patch
There was a problem hiding this comment.
I just saw it now,I'll change it
There was a problem hiding this comment.
This changes the meaning of the MM patch
There is already add suffixes （:^: and :） in Localization files.
| title = #PP_Parts_ProceduralStackDecoupler_title //Procedural Stack Decoupler | ||
| manufacturer = Kerbchem Industries | ||
| description = Made from viscoelastic nanopolymers (which were discovered by accident... growing in the back of the office mini-fridge) this decoupler can be stretched to accommodate a range of sizes. | ||
| description = #PP_Parts_ProceduralStackDecoupler_description //Made from viscoelastic nanopolymers (which were discovered by accident... growing in the back of the office mini-fridge) this decoupler can be stretched to accommodate a range of sizes. |
Source/ProceduralPart.cs
Outdated
| return true; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
You somehow managed to mark every line in this file as changed (different line endings?). This is no good.
| </ItemGroup> | ||
| <Copy SourceFiles="@(OutputFiles)" DestinationFolder="$(ProjectDir)..\GameData\ProceduralParts\Plugins\" /> | ||
| </Target> | ||
| </Project> |
There was a problem hiding this comment.
Same as above. The entire file is changed.
Source/ProceduralSRB.cs
Outdated
| float thrust1 = thrust * isp1 / isp0; | ||
| srbISP = $"{isp0:F0}s Vac / {isp1:F0}s ASL"; | ||
| thrustStats = $"{thrust0.ToStringSI(unit: "N", exponent: 3)} Vac / {thrust1.ToStringSI(unit: "N", exponent: 3)} ASL"; | ||
| srbISP = KSP.Localization.Localizer.Format("#PP_plugin_SRB_ISPInfo", Math.Round(isp0,1), Math.Round(isp1,1)); |
There was a problem hiding this comment.
Looks like this used to show 0 decimal digits but now you're rounding to show 1.
Source/TankContentSwitcher.cs
Outdated
| using System.Linq; | ||
| using UnityEngine; | ||
|
|
||
|
|
|
Do you have any other opinions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I Modified some of the source code, Parts configuration of this mod to it can support other language,
And Added Chinese translation.
Looking forward to your review.