Skip to content

[SCN] Sync Setsubun quotes with kcwikizh, sort entries according to ship id #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2024

Conversation

nizhf
Copy link
Contributor

@nizhf nizhf commented Feb 16, 2024

No description provided.

@sinsinpub
Copy link
Contributor

is this ready to be merged? or more commits are pending to add?

just realized... partial lines are all Traditional Chinese characters, for example, Natsugumo:
image
and yes zh.kcwiki.cn has both versions, so i think the script should be updated to fetch zh-cn page instead of zh-tw?

@nizhf
Copy link
Contributor Author

nizhf commented Feb 16, 2024

I also noticed many lines are in Traditional Chinese... I use the kcwikizh API https://api.kcwiki.moe/subtitles/detail to fetch all quotes. Many lines (especially for new ships) are in Traditional Chinese by default. Maybe that's because the translator uploaded them in TCN to kcwikizh. I will find a tool to convert these characters in my script. I will notify you once finished.

@nizhf
Copy link
Contributor Author

nizhf commented Feb 17, 2024

I used OpenCC to convert all lines to Simplified Chinese. They seem OK. I think this is ready to be merged. @sinsinpub

@sinsinpub sinsinpub merged commit de3338a into KC3Kai:master Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants