Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modern browser support for natively parsing query parameters #3

Conversation

tmack8001
Copy link
Contributor

@tmack8001 tmack8001 commented Jan 1, 2022

Details are within a thread on the Picobrewers facebook group between myself and Patrick on debugging why when clicking a link from Facebook wouldn't render.

Example of what doesn't work (shows a spinner): https://pbrecipes.beer/recipe.html?id=a37ad562c49046709edf4be9cc6a4ac0&second=parameter-incorrectly-parses-due-to-parsing-logic

According to https://caniuse.com/?search=URLSearchParams I believe most up to date browsers support the URLSearchParams API so we can rely on this. If people report issues we may need to make a shim to work around that.... but most should be using modern enough browsers these days.

@Justin-Credible Justin-Credible merged commit 80a4417 into Justin-Credible:master Jan 1, 2022
@Justin-Credible
Copy link
Owner

Merged and deployed. Thanks! 🍻

@tmack8001
Copy link
Contributor Author

Thanks for the quick review mate. Was an easy one there 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants