use modern browser support for natively parsing query parameters #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are within a thread on the Picobrewers facebook group between myself and Patrick on debugging why when clicking a link from Facebook wouldn't render.
Example of what doesn't work (shows a spinner): https://pbrecipes.beer/recipe.html?id=a37ad562c49046709edf4be9cc6a4ac0&second=parameter-incorrectly-parses-due-to-parsing-logic
According to https://caniuse.com/?search=URLSearchParams I believe most up to date browsers support the
URLSearchParams
API so we can rely on this. If people report issues we may need to make a shim to work around that.... but most should be using modern enough browsers these days.