Skip to content

add resource_group_id to create_integration_instance - full test coverage - updated examples - updated README #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2025

Conversation

SeaBlooms
Copy link

@SeaBlooms SeaBlooms commented Jul 31, 2025

  • added resource_group_id optional param to create_integration_instance method
  • created tests for all methods
  • created new example scripts for all methods
  • created new README for example scripts

@SeaBlooms SeaBlooms requested review from a team as code owners July 31, 2025 01:10
github-advanced-security[bot]

This comment was marked as outdated.

@SeaBlooms SeaBlooms changed the title add resource_group_id to create_integration_instance - full test coverage - updated README examples add resource_group_id to create_integration_instance - full test coverage - updated examples - updated README Jul 31, 2025
Copy link

@bjoepfeiffer bjoepfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. You may want to add resource group id to rules and dashbaords as well if you haven't already.

@SeaBlooms
Copy link
Author

This is great. You may want to add resource group id to rules and dashbaords as well if you haven't already.

create_alert_rule and update_alert_rule already support the resource_group_id today, and we dont have dashboard methods in the python client yet. we should be good to ship this as is

@SeaBlooms SeaBlooms merged commit c0c2be1 into main Jul 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants