Merge pull request #101 from thchr/patch-1

Remove redundant space insertion in `text` (fix #100)
JuliaWeb · Jan 2, 2025 · 78f07cb · 78f07cb · JamesWrigley · Jan 2, 2025
2 parents 86f3b75 + c94c9cd
commit 78f07cb
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Gumbo"
 uuid = "708ec375-b3d6-5a57-a7ce-8257bf98657a"
-version = "0.8.2"
+version = "0.8.3"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"

diff --git a/src/manipulation.jl b/src/manipulation.jl
@@ -42,7 +42,7 @@ function text(el::HTMLElement)
     io = IOBuffer()
     for c in AbstractTrees.PreOrderDFS(el)
         if c isa HTMLText
-            print(io, c.text, ' ')
+            print(io, c.text)
         end
     end
 

diff --git a/test/manipulation.jl b/test/manipulation.jl
@@ -0,0 +1,7 @@
+@testset "`text`" begin
+    doc = parsehtml("<em>foo</em>bar<em></em>baz")
+    @test text(doc.root) == "foobarbaz"
+
+    doc = parsehtml("<math><mrow><msub><mrow><mi>MoSe</mi></mrow><mrow><mn>2</mn></mrow></msub></mrow></math>")
+    @test text(doc.root) == "MoSe2"
+end
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -6,3 +6,4 @@ include("comparison.jl")
 include("parsing.jl")
 include("traversal.jl")
 include("io.jl")
+include("manipulation.jl")