Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make outputsize work with symbolically wrapped lux models #1508

Merged
merged 3 commits into from
Mar 29, 2025
Merged

make outputsize work with symbolically wrapped lux models #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49d9bcb
feat: make outputsize work with symbolically wrapped lux models
SebastianM-C Mar 27, 2025
edb23b0
test(lux_ext): add tests with symbolically wrapped models
SebastianM-C Mar 27, 2025
7dfe7d9
refactor: use getdefaultval
SebastianM-C Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ext/SymbolicsLuxExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module SymbolicsLuxExt
using Lux
using Symbolics
using Lux.LuxCore
using Lux.Random: AbstractRNG, default_rng
using Symbolics.SymbolicUtils

@static if isdefined(Lux.NilSizePropagation, :recursively_nillify)
Expand All @@ -11,9 +12,13 @@ using Symbolics.SymbolicUtils
end
end

function LuxCore.outputsize(model::SymbolicUtils.BasicSymbolic{<:LuxCore.AbstractLuxLayer}, x::Symbolics.Arr, rng::AbstractRNG)
LuxCore.outputsize(Symbolics.getdefaultval(model), x, rng)
end

@register_array_symbolic LuxCore.stateless_apply(
model::LuxCore.AbstractLuxLayer, x::AbstractArray, ps::Union{NamedTuple, <:AbstractVector}) begin
size = LuxCore.outputsize(model, Symbolics.wrap(x), LuxCore.Random.default_rng())
size = LuxCore.outputsize(model, Symbolics.wrap(x), default_rng())
eltype = Real
end

Expand Down
14 changes: 14 additions & 0 deletions test/extensions/lux.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ using ComponentArrays
Symbolics.@variables sym_ca[1:length(ca)] = ca
Symbolics.@variables sym_ps::typeof(ps) = ps
Symbolics.@variables sym_x[1:5] = Float32[1,2,3,4,5]
Symbolics.@variables sym_model::typeof(model) = model

out_ref = LuxCore.stateless_apply(model, x, ps)
@test out_ref isa Vector{Float32}
Expand Down Expand Up @@ -41,6 +42,12 @@ using ComponentArrays
@test length(out) == 6
out_sub = Symbolics.value.(Symbolics.substitute.(Symbolics.scalarize(out), (Dict(sym_x => x, sym_ca => ca),)))
@test out_sub == out_ref

out = LuxCore.stateless_apply(sym_model, sym_x, sym_ca)
@test out isa Symbolics.Arr
@test length(out) == 6
out_sub = Symbolics.value.(Symbolics.substitute.(Symbolics.scalarize(out), (Dict(sym_model => model, sym_x => x, sym_ca => ca),)))
@test out_sub == out_ref
end

@testset "Chain" begin
Expand All @@ -53,6 +60,7 @@ end
Symbolics.@variables sym_ca[1:length(ca)] = ca
Symbolics.@variables sym_ps::typeof(ps) = ps
Symbolics.@variables sym_x[1:5] = Float32[1, 2, 3, 4, 5]
Symbolics.@variables sym_model::typeof(model) = model

out_ref = LuxCore.stateless_apply(model, x, ps)
@test out_ref isa Vector{Float32}
Expand Down Expand Up @@ -83,4 +91,10 @@ end
@test length(out) == 3
out_sub = Symbolics.value.(Symbolics.substitute.(Symbolics.scalarize(out), (Dict(sym_x => x, sym_ca => ca),)))
@test out_sub == out_ref

out = LuxCore.stateless_apply(sym_model, sym_x, sym_ca)
@test out isa Symbolics.Arr
@test length(out) == 3
out_sub = Symbolics.value.(Symbolics.substitute.(Symbolics.scalarize(out), (Dict(sym_model => model, sym_x => x, sym_ca => ca),)))
@test out_sub == out_ref
end
Loading