[WIP] NEIM problem proposed solution #778
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr aims to solve this issue. Is still experimental and I havent tested it a lot.
Basically works like this:
When the code is in the matcher for a * operation, and at leas one of the factors of the * (in the lhs) has a power, check if the operation of data is a division, if yes continue the matching with data being transformed to a multiplication between the numerator of the division, and the denominator raised to a negative power.
So for example the rule
r_one = @rule a*b^(~n) => ~, if called withr_one(a/b)before this pr would skip the matching process, now instead continues the matching process with data transformed toa*(b^-1)