use normal entrypoints into base's display pipeline#736
Conversation
|
lol, guess the doctests are a good way of displaying what's changed... |
0516cde to
5e7647d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 84.40% 84.45% +0.05%
==========================================
Files 13 13
Lines 9374 9394 +20
==========================================
+ Hits 7912 7934 +22
+ Misses 1462 1460 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
187b579 to
2a637f6
Compare
4aba457 to
5de63a2
Compare
|
this last push just changed the if this should instead be actually benchmarked I can remove this change; or if we don't care it can remain fixed like this. the |
1ba3b0f to
7969cbe
Compare
|
I'd say this last commit fixes #420 as well; it's much more clear that it's an image of your actual matrix now that there's no aliasing |
afd9e00 to
18239c4
Compare
Base and SparseArrays had some funky interactions going on with replace_in_print_matrix, this fully disentangles the print funcs. it also makes SparseArrays smarter about swaping to braille, fixes aliasing, and generally makes printing more robust.
18239c4 to
1eb9e69
Compare
|
ok, I made a couple final tweaks and then sorted all the changes into 3 sensible commits. only have it separated out so it's easier to look at, can be squashed for merging; the first commit message counts for all three. any other changes you want me to make? |
Base and SparseArrays had some funky action-at-a-distance stuff going on, this fully disentangles the printing functions. this is what I really came over here for, the type thing was just me hoping to simplify things a bit. didn't end up effecting much, but does add the
circular_referenceline.it also makes SparseArrays a little smarter about when to swap to braille output, and actually uses the whole screen instead of just the left half. it's also theoretically doing less work now, but it's just a printing function so whatever. the width of displayed zeros also doesn't depend on the type anymore, and is always centered.
since this removes the error that used to come up during printing, I added in a new warning to replace it.
fixes: #21, #22, #233, #618