ReadOnly fixes: prevent adding some methods of size, axes, eltype
#649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On nightly Julia, this change prevents two sysimage invalidations triggered by defining two-argument `axes`.
* new types are not supposed to define `eltype` on instances * new subtypes of `AbstractArray` are not supposed to add methods to `eltype`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 12 12
Lines 9298 9298
=======================================
Hits 7813 7813
Misses 1485 1485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
approved these changes
Sep 14, 2025
nsajko
changed the title
ReadOnly fixesReadOnly fixes: prevent defining some methods of size, axes, eltype
nsajko
changed the title
ReadOnly fixes: prevent defining some methods of size, axes, eltypeReadOnly fixes: prevent adding some methods of size, axes, eltype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define only single-argument methods for
sizeandaxes.axes.Do not add the
eltypemethod.New types are not supposed to define
eltypeon instances.New subtypes of
AbstractArrayare not supposed to add methods toeltype.