-
Notifications
You must be signed in to change notification settings - Fork 36
Add correct storage_type for lazy wrapped GPU arrays (adjoint
, transpose
, Diagonal
)
#365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@servusdei2018 thanks for the hint! I've dropped the redundant vector and made the order of teststhe same for AMD and GPU |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 95.00% 94.26% -0.74%
==========================================
Files 17 20 +3
Lines 1100 1151 +51
==========================================
+ Hits 1045 1085 +40
- Misses 55 66 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you, and sorry for the delay! |
I noticed that storage_types aren't correctly determined for lazily wrapped GPU arrays. In this PR I dispatch the storage_type based on the parent of the wrapper