Skip to content

Bump compat for GeometryBasics, MeshCat, Mux, and OrderedCollections #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2022
Merged

Bump compat for GeometryBasics, MeshCat, Mux, and OrderedCollections #66

merged 3 commits into from
Jan 4, 2022

Conversation

@ferrolho
Copy link
Member

@ferrolho ferrolho commented Dec 1, 2021

No description provided.

@ferrolho
Copy link
Member Author

ferrolho commented Dec 12, 2021

The CI tests for this PR are failing because they require JuliaRobotics/MechanismGeometries.jl#31 to be merged and also MechanismGeometries.jl v0.7.0 to be tagged.

@ferrolho
Copy link
Member Author

ferrolho commented Dec 20, 2021 •
edited
Loading

Hmm, I believe the problem is now due to RigidBodyDynamics.jl not being up-to-date. However, this is a chicken-and-egg kind of situation, because JuliaRobotics/RigidBodyDynamics.jl#629 requires this MeshCatMechanisms.jl PR.

Btw, the reason why the tests fail on JuliaRobotics/RigidBodyDynamics.jl#629 (at least on my local machine) is because of the notebook tests, not the library itself. I have updated each notebooks' manifest, but some of them (e.g., notebook 4) can't resolve MeshCat v0.14 because that would require this MeshCatMechanisms.jl PR.

rdeits
rdeits reviewed Dec 20, 2021
View reviewed changes
Project.toml Outdated
MeshCat = "0.13"
Mux = "0.7.1"
MeshCat = "0.13, 0.14"
Mux = "0.7"
Copy link
Collaborator

@rdeits rdeits Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the 0.7.1 here since there was some issue with 0.7

@rdeits
Copy link
Collaborator

rdeits commented Dec 20, 2021

Ok, makes sense. I'm fine with merging this to unblock things once the mux compat is resolved

@rdeits rdeits merged commit 48db720 into JuliaRobotics:master Jan 4, 2022
@ferrolho ferrolho deleted the hf/compat branch January 4, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdeits rdeits rdeits left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ferrolho @rdeits