Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: DynamicPPL v0.33.0 #122588

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jan 8, 2025

## Breaking changes

- `values_as_in_model()` now requires an extra boolean parameter, specifying whether variables on the lhs of `:=` statements are to be included in the resulting OrderedDict of values. The type signature is now `values_as_in_model([rng,] model, include_colon_eq::Bool [, varinfo, context])`

## Other changes

- Moved the implementation of `predict` from Turing.jl to DynamicPPL.jl; the user-facing behaviour is otherwise the same
- Improved error message when a user tries to initialise a model with parameters that don't correspond strictly to the underlying VarInfo used

JuliaRegistrator referenced this pull request in TuringLang/DynamicPPL.jl Jan 8, 2025
* improve error message for `initial_params`

* Update src/sampler.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix logic error

* apply Will's suggestions

* bump version

* Update src/sampler.jl

Co-authored-by: Penelope Yong <[email protected]>

* Update Project.toml

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Penelope Yong <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-dynamicppl-366bfd00-v0.33.0-ffd2d6d13f branch from 35e6b34 to 863e508 Compare January 8, 2025 12:36
UUID: 366bfd00-2699-11ea-058f-f148b4cae6d8
Repo: https://github.com/TuringLang/DynamicPPL.jl.git
Tree: bacb8847cff6ef9456a8db009b03bfb8fe7fbfa5

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-dynamicppl-366bfd00-v0.33.0-ffd2d6d13f branch from 863e508 to 377565e Compare January 10, 2025 16:21
@JuliaTagBot JuliaTagBot merged commit f5535ed into master Jan 10, 2025
9 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-dynamicppl-366bfd00-v0.33.0-ffd2d6d13f branch January 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants