Skip to content

Remove dead code supporting old versions of Julia/Python #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Conversation

cjdoris
Copy link
Collaborator

@cjdoris cjdoris commented Jul 19, 2025

This PR removes dead code that was supporting old versions of Julia and Python:

Changes:

  • Remove fallback to Py_Finalize() for Python < 3.6, always use Py_FinalizeEx()
  • Update minimum Python version check from 3.5+ to 3.9+ (aligns with recent version bump)
  • Remove Py_Finalize function signature, keeping only Py_FinalizeEx
  • Simplify pointer initialization by removing conditional logic
  • Remove Julia version check for stacktrace formatting (< 1.6.0), keep only modern formatting

Files changed:

  • src/C/context.jl: Simplified finalization and version checking
  • src/C/pointers.jl: Removed legacy function signatures
  • src/Core/err.jl: Removed legacy stacktrace formatting

Net reduction of 18 lines, making the codebase cleaner by removing compatibility shims that are no longer needed.

@cjdoris cjdoris merged commit b9fee86 into main Jul 19, 2025
14 checks passed
@cjdoris cjdoris deleted the dead-code branch July 19, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant