-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor #599
base: main
Are you sure you want to change the base?
Conversation
@cjdoris @MilesCranmer |
You will yeah but don't bother yet - this PR is likely to change some more. Sorry for the delay on reviewing your PR, my time is currently limited and focused on bugs, improving code quality and working towards v1, rather than new features, but I will get to it. |
Refactoring the codebase, which has got a bit out of hand.
Internals
submodulesrc/API/API.jl
use a commonhave each internal submodule export its internal API so other submodules can just doInternals.Common
module which exports common functionality instead of needing to import functions from all over the placeusing ..Foo
to get everything it needsPyList
etc withinWrap
maybe move testitems from test to src?