Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODATA2022 module #39

Merged
merged 8 commits into from
Jan 3, 2025
Merged

Conversation

mikeingold
Copy link
Contributor

@mikeingold mikeingold commented Dec 31, 2024

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.84%. Comparing base (097613c) to head (3e5bfc2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/codata2022.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   77.19%   69.84%   -7.36%     
==========================================
  Files           3        4       +1     
  Lines          57       63       +6     
==========================================
  Hits           44       44              
- Misses         13       19       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Only a comment about the docs

@@ -65,7 +65,7 @@ the constant, use `measurement(x)`:
```julia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these codeblocks should probably be jldoctests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and it caught an error where the second code block didn't have its own explicit import.

@giordano
Copy link
Member

giordano commented Jan 3, 2025

Thanks!

@giordano giordano merged commit 62bf9a5 into JuliaPhysics:master Jan 3, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CODATA 2022 is available
2 participants