-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODATA2022 module #39
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 77.19% 69.84% -7.36%
==========================================
Files 3 4 +1
Lines 57 63 +6
==========================================
Hits 44 44
- Misses 13 19 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Only a comment about the docs
docs/src/usage.md
Outdated
@@ -65,7 +65,7 @@ the constant, use `measurement(x)`: | |||
```julia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these codeblocks should probably be jldoctests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and it caught an error where the second code block didn't have its own explicit import.
Thanks! |
Based on: https://www.nist.gov/publications/codata-internationally-recommended-2022-values-fundamental-physical-constants
Closes #34