Do not hard fail in test_errorhandler.jl with unknown implementations
#542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
reviewed
Feb 21, 2022
test/runtests.jl
Outdated
| @test !success(r) | ||
| elseif f == "test_errorhandler.jl" && MPI.identify_implementation()[1] == MPI.UnknownMPI |
There was a problem hiding this comment.
We should provide some more generic mechanism for excluding specific tests (or allowing them to fail)
vchuravy
approved these changes
Mar 2, 2022
giordano
force-pushed
the
mg/handle-error-handler
branch
from
467c1e1 to
7fd99de
Compare
giordano
commented
Apr 18, 2022
vchuravy
reviewed
Apr 18, 2022
giordano
force-pushed
the
mg/handle-error-handler
branch
from
7fd99de to
2ecd682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #539 (comment). The idea is to not make tests hard-fail on custom error handlers with unknown ABIs, since it's known that they may not be implemented. @simonbyrne what do you think about this? With this change, tests of
MPI.jlv0.19.2 are successful on Fugaku with system (Fujitsu) MPI, albeit with a broken test.