Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Recipe: CPUInfo v0.0.20200122 #4555

Merged
merged 8 commits into from
Mar 6, 2022
Merged

New Recipe: CPUInfo v0.0.20200122 #4555

merged 8 commits into from
Mar 6, 2022

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Mar 6, 2022

Packaging similar to libcpuinfo0 in Ubuntu.

Starting with an old version - used by PyTorch v1.5.

@stemann
Copy link
Contributor Author

stemann commented Mar 6, 2022

@giordano Any idea why the Windows x86_64 build outputs a .dll.a "library"? I tried just naively renaming it, but it's not the proper object file type (COFF?).

@giordano
Copy link
Member

giordano commented Mar 6, 2022

The *.dll.a isn't a dynamic library but an import library.

@giordano
Copy link
Member

giordano commented Mar 6, 2022

@stemann
Copy link
Contributor Author

stemann commented Mar 6, 2022

@stemann
Copy link
Contributor Author

stemann commented Mar 6, 2022

Judging by the log, the library is compiled https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=17888&view=logs&j=e919827e-2bea-5cb6-e233-5480b9308c51&t=b8c4887f-47c5-564a-0700-a9fc4ceb14a8&l=248 but not installed?

And indeed, it was there. Silly Windows builds... :-)

@stemann stemann marked this pull request as ready for review March 6, 2022 18:53
@stemann stemann marked this pull request as draft March 6, 2022 18:59
@giordano
Copy link
Member

giordano commented Mar 6, 2022

Any tips for getting aarch64-macos going?

No

@stemann stemann marked this pull request as ready for review March 6, 2022 19:08
@stemann
Copy link
Contributor Author

stemann commented Mar 6, 2022

Will enable i686-windows and x86_64-freebsd in a later version.

@giordano
Copy link
Member

giordano commented Mar 6, 2022

Will enable i686-windows and x86_64-freebsd in a later version.

I'm confused, why? Didn't they work in https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=17894&view=results?

@stemann
Copy link
Contributor Author

stemann commented Mar 6, 2022

Will enable i686-windows and x86_64-freebsd in a later version.

I'm confused, why? Didn't they work in https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=17894&view=results?

The overall aim is to provide dependencies for Torch, notably XNNPACK which takes a long time to build - for #4554.

I thought I would start with something simple CPUInfo - and a sufficiently old version that I would not be missing some random version for all the PyTorch projects that depend on CPU Info.

@@ -0,0 +1,13 @@
diff --git a/src/x86/windows/init.c b/src/x86/windows/init.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to upstream this patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They actually already have fixed that - luckily :-)

@giordano giordano merged commit 7ec0989 into JuliaPackaging:master Mar 6, 2022
@stemann stemann deleted the wizard/CPUInfo-v0.0.20200122_fe6bdc42 branch March 6, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants