Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Runner] Updated xcrun executable to handle a few arguments #392

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[Runner] Updated xcrun executable to handle a few arguments #392

wants to merge 6 commits into from

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Dec 1, 2024 •
edited
Loading

Updated xcrun executable to handle --sdk, --show-sdk-path and --show-sdk-version.

Also, added SDKROOT env. var.

Usages of xcrun --show-sdk-path etc.:

Expected behaviour

$ xcrun echo foo
foo

$ xcrun --show-sdk-path
/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root

$ xcrun --show-sdk-version
10.12

$ xcrun --show-sdk-path --show-sdk-version
/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root
10.12

$ xcrun --show-sdk-path --show-sdk-version echo foo
/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root
10.12
foo

$ xcrun --sdk /opt/$target/$target/sys-root --show-sdk-path --show-sdk-version echo foo
/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root
10.12
foo

$ xcrun --sdk $WORKSPACE/srcdir/MacOSX14.0.sdk --show-sdk-path --show-sdk-version echo foo
/workspace/srcdir/MacOSX14.0.sdk
14.0
foo

@stemann
[Runner] Updated xcrun executable to handle --sdk, `--show-sdk-path…
a1fefa0 
…` and `--show-sdk-version`.

Also, added SDKROOT env. var.
@stemann stemann marked this pull request as ready for review February 19, 2025 20:02
giordano
giordano reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate preserving the same style

@stemann
Copy link
Contributor Author

stemann commented Feb 25, 2025

All suggestions applied

@stemann stemann requested a review from giordano March 23, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano Awaiting requested review from giordano

Assignees
No one assigned
Labels
runner 🏃‍♀️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stemann @giordano