CMake changes: Long double/double size detection, Android x86 and armv7 support, install pkg-config pc file#304
Merged
ViliusSutkus89 merged 6 commits intoJuliaMath:masterfrom Jun 25, 2024
Conversation
Hardcoded config value provided wrong value for Android i686.
Member
|
@ViliusSutkus89 Happy to give you commit access here. Please let me know if ok. |
Collaborator
Author
|
Sure. I can't be a full time maintainer, but I'll try to help whenever I can |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 38.24% 39.02% +0.78%
==========================================
Files 233 233
Lines 6139 6144 +5
Branches 1607 1608 +1
==========================================
+ Hits 2348 2398 +50
+ Misses 3394 3393 -1
+ Partials 397 353 -44 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Updated PR with a patch to match version in CMake with the version in Autotools |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR has the following changes:
Also, when we release, we need to update version number at the top of CMakeLists.txt file, otherwise the generated pkg-config openlibm.pc file will report the wrong version. I've set the version to 0.8.4 in advance. I don't really care about it, because I don't use pkg-config.pc file, I'm just saying what would be the consequences of not incrementing the version number.
Where do we set the version number for pkg-config.pc file generated by autotools?
Once again, #299 will require a merge commit, because it's the same file we are editing, but we touched different lines, so we should be good.
Regards