Skip to content

fix ellipk and ellipe #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix ellipk and ellipe #499

wants to merge 2 commits into from

Conversation

ogauthe
Copy link

@ogauthe ogauthe commented Jul 9, 2025

Fix #498
also fixes ellipe.

@JeffreySarnoff
Copy link
Member

This looks good to me. Merge ready.
If you want, as the type here is Float64, triple-equals can be used to check for -Inf.

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (31e3c1a) to head (2575b8b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   94.07%   94.12%   +0.04%     
==========================================
  Files          14       14              
  Lines        2905     2909       +4     
==========================================
+ Hits         2733     2738       +5     
+ Misses        172      171       -1     
Flag Coverage Δ
unittests 94.12% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ellipk(NaN) throws UndefVarError
2 participants