Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redefine scalar_div to avoid undesirable type conversion #496

Merged
merged 4 commits into from
Apr 26, 2023
Merged

redefine scalar_div to avoid undesirable type conversion #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09c239a
redefine scalar_div to avoid undesirable type conversion
jverzani Apr 25, 2023
2c90501
guard for 0 poly
jverzani Apr 25, 2023
c67ab29
both are method errors
jverzani Apr 25, 2023
a90cc5e
use _convert
jverzani Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = "Polynomials"
uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
license = "MIT"
author = "JuliaMath"
version = "3.2.9"
version = "3.2.10"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Expand Down
7 changes: 5 additions & 2 deletions src/common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,8 +1048,11 @@ end
scalar_mult(p1::AbstractPolynomial, p2::AbstractPolynomial) = error("scalar_mult(::$(typeof(p1)), ::$(typeof(p2))) is not defined.") # avoid ambiguity, issue #435

# scalar div
Base.:/(p::P, c::S) where {P <: AbstractPolynomial,S} = scalar_div(p, c)
scalar_div(p::AbstractPolynomial, c) = scalar_mult(p, inv(c))
Base.:/(p::AbstractPolynomial, c) = scalar_div(p, c)
function scalar_div(p::P, c::S) where {S, T, X, P<:AbstractPolynomial{T, X}}
iszero(p) && return zero(⟒(P){Base.promote_op(/,T,S), X})
_convert(p, coeffs(p) ./ Ref(c))
end

## Polynomial p*q
## Polynomial multiplication formula depend on the particular basis used. The subtype must implement
Expand Down
8 changes: 7 additions & 1 deletion test/StandardBasis.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ end
@test_throws MethodError q * p == P(conv([a,b], [a,b, c])) # Ok, no * for T

# poly powers
@test_throws MethodError p^2 == p * p # Ok, no * for T
@test_throws MethodError p^2 # Ok, no * for T
@test_throws MethodError p * p

# evaluation
@test p(s) == a + b * s + c * s * s
Expand Down Expand Up @@ -525,6 +526,11 @@ end
@test p - p == 0*p
end
end

# issue #495, (scalar div fix)
𝐐 = Rational{Int}
v = Polynomial{𝐐}([0//1])
@test eltype(integrate(v)) == 𝐐
end

@testset "Divrem" begin
Expand Down