Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bytestring with unsafe_string #82

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

giordano
Copy link
Member

Fix #63.

@ludvigak
Copy link
Collaborator

I think bytestring should be replaced with unsafe_string, not string.

Also, it might make more sense to put all the changes to custom_error_handler mentioned in #84 in one PR, i.e. also change to @warn and supply arguments to the exceptions, since this PR by itself is not yet functional.

@giordano
Copy link
Member Author

I think bytestring should be replaced with unsafe_string, not string.

I think you're right, I've updated the PR.

Also, it might make more sense to put all the changes to custom_error_handler mentioned in #84 in one PR, i.e. also change to @warn and supply arguments to the exceptions, since this PR by itself is not yet functional.

Well, this PR has nothing to do with the custom_error_handler and fixes a reported issue, it just happened that I found out the issues with that function while trying to reproduce #63.

@giordano giordano changed the title Replace bytestring with string Replace bytestring with unsafe_string Oct 22, 2018
@ludvigak
Copy link
Collaborator

You're right of course. I was just thinking that the example in #63 still fails, though there are currently three separate reasons why it fails. Didn't mean to complain when you're the one actually trying to fix thing =)

@giordano giordano merged commit 7aa8c76 into JuliaMath:master Oct 26, 2018
@giordano giordano deleted the bytestring branch October 26, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants