-
Notifications
You must be signed in to change notification settings - Fork 55
[Enzyme] Mark assert applicable as non-differentiable #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 70.99% 70.73% -0.27%
==========================================
Files 5 6 +1
Lines 531 533 +2
==========================================
Hits 377 377
- Misses 154 156 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@stevengj mind giving this a review? |
Add a downstream test of Enzyme differentiation on FFTW? |
It doesn’t yet differentiate it fully, but this is a necessary pre requisite |
I suspect this needs to add Enzyme to the extras to make Pkg happy. But also, might be easier to move the extension to Enzyme? Pkgextensions are symmetrical, it doesn't really matter which of the two packages hosts them. |
Yeah that’s always an option. My inclination here is to put in an FFTW extension since the functions marked inactive are really internals to fftw and I’d prefer not to touch internals of a package from another package. FFTW.jl doesn’t change that much though so it might be fine |
This is relevant: https://discourse.julialang.org/t/autodifferentiation-with-fft-with-enzyme/128674/2. CC @danielwe |
Rules should probably live in AbstractFFTs.jl. There's an abandoned draft PR: JuliaMath/AbstractFFTs.jl#103. If you intercept at that level, you probably don't need to worry about marking any FFTW.jl internals inactive---at least I haven't needed that for the rule I shared on Discourse to work. |
No description provided.