-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KMedoids #298
Add KMedoids #298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
==========================================
+ Coverage 98.17% 98.24% +0.07%
==========================================
Files 48 49 +1
Lines 1367 1424 +57
==========================================
+ Hits 1342 1399 +57
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think the only point that we don't have a simple way to resolve would be the type of So I think starting it as |
Perhaps we can evaluate the distance with a single row to get the type.
Will try when I'm back to the computer.
Em qui., 27 de mar. de 2025, 19:10, Elias Carvalho ***@***.***>
escreveu:
… ***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#298 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3LHTWXJQSPRRCM5EYD2WRZM5AVCNFSM6AAAAABZ53TJECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMRTGQ3TQMZQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There is still an issue regarding unitful columns with different units, but that should be addressed in TableDistances.jl. If distances are computed with different units, and these units can't be added, we will get an error. Perhaps TableDistances.jl should remove the units to make it work, or warn users that columns must have compatible units. |
I am going to merge assuming that the last review was an approval with comment 👍🏽 |
Amazing PR @juliohm! |
Quick correction: the |
No description provided.