revert: try to coalesce screen updates #59848
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
system:windows
|
IIUC, this is for post v1.13 branch merge (so the code is available in v1.13 in case someone is using a recent version that doesn't support bracketed paste and wants to re-enable it locally). I don't know what other bugs were introduced such that pressing each individual key now is very slow |
Could you elaborate on this? |
|
When originally merged, that PR could render the whole screen update for that amount of text in less than a second even on Windows, and now apparently it can't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively reverts #39538 since this code is now:
Ref #59827 (comment)