-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix called-argument analysis for calls with splat #58070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
53 tasks
|
It is an llvm bug (or rather, our bug in what we codegen for llvm). I'm looking into why we did what we did |
vtjnash
added a commit
that referenced
this pull request
May 8, 2025
vtjnash
added a commit
that referenced
this pull request
May 8, 2025
Fix some misuses of `jl_is_immutable_datatype`, and rename it to indicate it is not a guarantee of immutable. Refs: #58070 The cfunction code difference isn't normally emitted by codegen since it is just a fallback, but can be observed with various code_llvm type signatures for various combinations of abstract/union/concrete/mutable: f(x::T) where {T} = @cfunction identity Ref{T} (Ref{T},) code_llvm(f, (Any,), dump_module=true, raw=true) code_llvm(f, (Number,), dump_module=true, raw=true) code_llvm(f, (Union{Int32,Int64},), dump_module=true, raw=true) code_llvm(f, (Complex,), dump_module=true, raw=true) code_llvm(f, (Ref{Int},), dump_module=true, raw=true)
vtjnash
added a commit
that referenced
this pull request
May 8, 2025
Fix some misuses of `jl_is_immutable_datatype`, and rename it to indicate it is not a guarantee of immutable. Refs: #58070 The cfunction code difference isn't normally emitted by codegen since it is just a fallback, but can be observed with various code_llvm type signatures for various combinations of abstract/union/concrete/mutable: f(x::T) where {T} = @cfunction identity Ref{T} (Ref{T},) code_llvm(f, (Any,), dump_module=true, raw=true) code_llvm(f, (Number,), dump_module=true, raw=true) code_llvm(f, (Union{Int32,Int64},), dump_module=true, raw=true) code_llvm(f, (Complex,), dump_module=true, raw=true) code_llvm(f, (Ref{Int},), dump_module=true, raw=true)
vtjnash
added a commit
that referenced
this pull request
May 9, 2025
KristofferC
pushed a commit
that referenced
this pull request
May 12, 2025
KristofferC
pushed a commit
that referenced
this pull request
May 12, 2025
(cherry picked from commit bbb0582)
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
charleskawczynski
pushed a commit
to charleskawczynski/julia
that referenced
this pull request
May 12, 2025
KristofferC
pushed a commit
to DilumAluthgeBot/julia
that referenced
this pull request
May 12, 2025
…Lang#58356) Refs: JuliaLang#58070 (cherry picked from commit f07565f)
KristofferC
pushed a commit
that referenced
this pull request
Jun 5, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jun 5, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jun 5, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.