verify that optimize_until is a valid pass
#58033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
the
compiler:optimizer
KristofferC
force-pushed
the
kc/verify_optimize_until
branch
2 times, most recently
from
8ba7efd to
bb8d27a
Compare
aviatesk
force-pushed
the
kc/verify_optimize_until
branch
from
bb8d27a to
3094abc
Compare
Keno
reviewed
Apr 8, 2025
Compiler/src/optimize.jl
Outdated
| ) | ||
| if optimize_until isa String && !(optimize_until in ALL_PASS_NAMES) |
There was a problem hiding this comment.
I'm not sure we have enough infrastructure in the compiler world to actually run this in test, but since we never call it from there anyway, I guess that's not a problem.
There was a problem hiding this comment.
I can change it to a loop?
There was a problem hiding this comment.
We can use Base.Compiler.contains_is for this. I will make the changes quickly.
KristofferC
force-pushed
the
kc/verify_optimize_until
branch
from
1fee392 to
0141925
Compare
aviatesk
force-pushed
the
kc/verify_optimize_until
branch
from
4171256 to
021bb73
Compare
KristofferC
added a commit
that referenced
this pull request
Apr 26, 2025
I've noticed a few places in tests where `optimize_until` is called with a non-existent pass name. This is an attempt to catch those places and hopefully prevent further possible regressions when someone renames a pass and forgets to update the tests that matches on that name. --------- Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit 8681bb8)
KristofferC
added a commit
that referenced
this pull request
Apr 26, 2025
I've noticed a few places in tests where `optimize_until` is called with a non-existent pass name. This is an attempt to catch those places and hopefully prevent further possible regressions when someone renames a pass and forgets to update the tests that matches on that name. --------- Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit 8681bb8)
KristofferC
added a commit
that referenced
this pull request
Apr 26, 2025
I've noticed a few places in tests where `optimize_until` is called with a non-existent pass name. This is an attempt to catch those places and hopefully prevent further possible regressions when someone renames a pass and forgets to update the tests that matches on that name. --------- Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit 8681bb8)
KristofferC
added a commit
that referenced
this pull request
Apr 26, 2025
I've noticed a few places in tests where `optimize_until` is called with a non-existent pass name. This is an attempt to catch those places and hopefully prevent further possible regressions when someone renames a pass and forgets to update the tests that matches on that name. --------- Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit 8681bb8)
KristofferC
added a commit
that referenced
this pull request
Apr 26, 2025
I've noticed a few places in tests where `optimize_until` is called with a non-existent pass name. This is an attempt to catch those places and hopefully prevent further possible regressions when someone renames a pass and forgets to update the tests that matches on that name. --------- Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit 8681bb8)
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
I've noticed a few places in tests where `optimize_until` is called with a non-existent pass name. This is an attempt to catch those places and hopefully prevent further possible regressions when someone renames a pass and forgets to update the tests that matches on that name. --------- Co-authored-by: Shuhei Kadowaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a few places in tests where
optimize_untilis called with a non-existent pass name. This is an attempt to catch those places and hopefully prevent further possible regressions when someone renames a pass and forgets to update the tests that matches on that name.