Fix getall failure with MMTk dependency #57038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-netto
force-pushed
the
fix-mmtk-getall
branch
from
5072786 to
eb0dec6
Compare
d-netto
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #57002. The current makefile checks if
MMTK_JULIA_DIRpoints to$(BUILDROOT)/usr/lib/mmtk_juliaand defines the ruleget-mmtk_juliaif the condition is met. For non-mmtk builds (e.g.make -C deps getall),MMTK_JULIA_DIRis not defined, thusget-mmtk_juliais not defined. This PR moves the ruleget-mmtk_juliaoutside the condition so it always exists.