Start excising LinearAlgebra #51904
Closed
Start excising LinearAlgebra #51904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…51641) The problem with the `delete_method` in `__init__` approach is that we invalidate the method-table, after we have performed all of the caching work. A package dependent on `Random`, will still see the stub method in Base and thus when we delete the stub, we may invalidate useful work. Instead we delete the methods when Random is being loaded, thus a dependent package only ever sees the method table with all the methods in Random, and non of the stubs methods. The only invalidation that thus may happen are calls to `rand` and `randn` without first doing an `import Random`.
During `./julia -e import SparseArrays` We would see an "method overwritting" not supported during precompilation, as far as I figured out this is due to the check searching for methods active in the world prior. So adding a bit of distance avoids that check.
3 tasks
vchuravy
force-pushed
the
vc/excise_random
branch
from
b80489b to
b038633
Compare
vchuravy
force-pushed
the
vc/excise_random
branch
from
0fc6400 to
923efb9
Compare
vchuravy
added
the
help wanted
Contributor
|
Out of curiosity, why was this PR abandoned? |
Member
|
LinearAlgebra was moved to its own repo in #56637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.