Scanner object considering multiple coils #548
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cncastillo
requested changes
Mar 14, 2025
cncastillo
force-pushed
the
scanner-develop
branch
from
d84cb1e to
be1d62b
Compare
…dd a getprperty to the Scanner.limits.symbol values.
cncastillo
requested changes
Mar 17, 2025
…mpact] and another small changes
cncastillo
requested changes
Mar 17, 2025
…sens for RFCoilSensDefinedAtPhantomPositions
cncastillo
requested changes
Mar 31, 2025
KomaMRIBase/src/datatypes/Scanner.jl
Outdated
| @@ -108,6 +108,14 @@ function getproperty(sys::Scanner, key::Symbol) | |||
| end | |||
| end | |||
|
|
|||
| function Base.setproperty!(sys::Scanner, key::Symbol, value) | |||
| if key in fieldnames(HardwareLimits) | |||
| setfield!(sys.limits, key, convert(Float64, value)) # Convert value to the correct type | |||
There was a problem hiding this comment.
Don't convert inside. This is going to generate type stability problems.
There was a problem hiding this comment.
Solved at bbbb559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generation of a flexible and extensible Scanner object, to controll Hardware Limits, Gradient Behaviour, RF behaviour and magnetic field inhomegeneities.
Based in the pull request #454 and solving the issue #150 , this PR decouple the coils definition from the Phantom structure.
Clone this branch to test it using Julia Pkg: