Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Align (fix #79) #81

Closed
wants to merge 2 commits into from
Closed

Conversation

thchr
Copy link
Collaborator

@thchr thchr commented Mar 28, 2025

Here's an implementation of the covariance approach suggested in #79, focusing just on 2D.

I'm open to suggestions for how it could be extended to 3D in a general way - but I couldn't immediately imagine a nice and unified interface (we would need to align to two axes in 3D).

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 94.29%. Comparing base (c9e417a) to head (aabbbbb).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/align.jl 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   97.44%   94.29%   -3.16%     
==========================================
  Files           9       10       +1     
  Lines         549      578      +29     
==========================================
+ Hits          535      545      +10     
- Misses         14       33      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hexaeder
Copy link
Collaborator

I invited you to the repo. Do you mind recreating the PR from an internal branch rather than your fork? That way we get the doc preview.

@thchr
Copy link
Collaborator Author

thchr commented Mar 28, 2025

Superseded by #82.

@thchr thchr closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants