Skip to content

Make Julia v1.10 (LTS) min version #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonschoelly
Copy link
Member

@simonschoelly simonschoelly commented May 21, 2025

This PR makes Julia v1.10 - the latest long-term support version the minimum version of this package.

Additionally

  • Remove some code that was only necessary for older versions
  • Remove Compat.jl dependency as it is not needed anymore (we can always add it back)
  • Add tests for squash(::AbstractGraph) in order to not decrease code coverage

I noticed there are some TODO comments for changing the error types in some cases when we upgrade Julia - I left them in for now as this might be a slightly breaking case.

@simonschoelly simonschoelly self-assigned this May 21, 2025
@simonschoelly simonschoelly added the dependencies Pull requests that update a dependency file label May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (24539fd) to head (d9f049e).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   97.30%   97.41%   +0.10%     
==========================================
  Files         117      120       +3     
  Lines        6948     6953       +5     
==========================================
+ Hits         6761     6773      +12     
+ Misses        187      180       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am strongly in favor. A cursory look through the edits does not raise any issues for me, but I am not deeply familiar with the codebase yet. LGTM for what is worth.

@simonschoelly
Copy link
Member Author

I am strongly in favor. A cursory look through the edits does not raise any issues for me, but I am not deeply familiar with the codebase yet. LGTM for what is worth.

Thanks. Most of the changes was the removal of the @compat macro - we needed that because ismutable was not available before Julia v1.7. And then these changes lowered the coverage percentage so I added a test to bring the percentage back up.

@simonschoelly simonschoelly merged commit fb9c1d1 into JuliaGraphs:master May 22, 2025
12 checks passed
@simonschoelly simonschoelly deleted the make-julia-v1.10-min-version branch May 22, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants