This repository was archived by the owner on Mar 12, 2021. It is now read-only.
Upstream ldiv! overload #580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiffEqBase.jl has been carrying an ldiv! overload to make it work for awhile (https://github.com/JuliaDiffEq/DiffEqBase.jl/blob/master/src/init.jl#L148-L152), and I think it might be a good time to upstream it.
|
Thanks! Want to add a test? |
|
test added |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 4, 2020
580: Upstream ldiv! overload r=maleadt a=ChrisRackauckas DiffEqBase.jl has been carrying an ldiv! overload to make it work for awhile (https://github.com/JuliaDiffEq/DiffEqBase.jl/blob/master/src/init.jl#L148-L152), and I think it might be a good time to upstream it. Co-authored-by: Christopher Rackauckas <[email protected]>
Build failed |
|
@ChrisRackauckas The CI failure looks related? |
|
Would it make sense to make https://github.com/JuliaGPU/CuArrays.jl/blob/master/src/linalg.jl take use of this? |
|
Emmm. Together with |
|
But that implementation cannot reuse factorizations, so this is a lot faster in practice. |
|
Good point! |
|
I guess we should keep both then. I use |
|
It's also possible there's a better way to do this, but I haven't found it 🤷♂ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiffEqBase.jl has been carrying an ldiv! overload to make it work for awhile (https://github.com/JuliaDiffEq/DiffEqBase.jl/blob/master/src/init.jl#L148-L152), and I think it might be a good time to upstream it.